Fix database prefixes and a lot of other small things#22
Merged
Conversation
TamaroWalter
force-pushed
the
fix/db_settings_overall
branch
from
21b495d to
2512b0c
Compare
dlmsr
force-pushed
the
fix/db_settings_overall
branch
2 times, most recently
from
e91db63 to
2983220
Compare
The table was build manually using echo statements. The UI therefore looked out of place. Now, it uses \core_table\flexible_table which does the HTML rendering for us.
The pg_lite class checks if the result of pg_connection_status() is false. However, a good connection status (PGSQL_CONNECTION_OK) equals the integer 0 which the operator == concerns equal to false. So a failed connection is stated although the connection is okay.
if the types are stated moodle_form complains: Declaration must be compatible with moodleform->validation(data: array, files: array)
The bitwise & caused installation failures and is also semantically wrong since assign_capability returns boolean values.
11 tasks
dlmsr
force-pushed
the
fix/db_settings_overall
branch
from
2983220 to
32e1610
Compare
After initiating a helptable update one was stuck on this update_helptable.php page which just shows an empty page.
As many lsf-categories can map to the same Moodle category, the 'mdlid' is not an unique array key. In one testcase Moodle complained about it.
dlmsr
force-pushed
the
fix/db_settings_overall
branch
from
32e1610 to
3eee595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔀 Purpose of this PR:
📝 Description:
This PR has different little fixes from bugs that occurred from previous commits as well as older bugs that were found during testing through the plugin.
At this state, i can successfully create courses based on the lsf_view tables that i get through the 'update_helptable' cronjob.
Note: This branch was created from another feature-branch that was not merged to main, but is now.