chore: publish to marketplaces independently and handle partial failures#758
Merged
mhuisi merged 1 commit intoleanprover:masterfrom Apr 13, 2026
Merged
chore: publish to marketplaces independently and handle partial failures#758mhuisi merged 1 commit intoleanprover:masterfrom
mhuisi merged 1 commit intoleanprover:masterfrom
Conversation
Previously, `vsce publish` and `ovsx publish` ran sequentially in the same step, so a failure in one would skip the other and also skip the GitHub release creation. Split them into independent jobs so that: - A failure in one marketplace doesn't prevent publishing to the other. - The GitHub release is still created on partial failure (via `if: !cancelled()` on the release job), with a warning banner in the release body naming the marketplace(s) that failed. - Maintainers can use "Re-run failed jobs" in the Actions UI to retry the failed publish against the same tag without rebuilding. Also split `build-and-test` into `build` (ubuntu only, produces the `.vsix` artifact) and `test` (matrix, runs lint and tests) so that the publish jobs depend only on `build`. This preserves the previous behavior where tests don't gate publishing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> chore: publish to marketplaces independently and handle partial failures Previously, `vsce publish` and `ovsx publish` ran sequentially in the same step, so a failure in one would skip the other and also skip the GitHub release creation. Split them into independent jobs so that: - A failure in one marketplace doesn't prevent publishing to the other. - The GitHub release is still created on partial failure (via `if: !cancelled()` on the release job), with a warning banner in the release body naming the marketplace(s) that failed. - Maintainers can use "Re-run failed jobs" in the Actions UI to retry the failed publish against the same tag without rebuilding. Also split `build-and-test` into `package` (ubuntu only, produces the `.vsix` artifact and runs the npm workspace publishes) and a new `build-and-test` (matrix, builds from scratch and runs lint + tests) so that the publish jobs depend only on `package`. This preserves the previous behavior where tests don't gate publishing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mhuisi
force-pushed
the
push-oszltqkszyvr
branch
from
3b27b57 to
4909613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
vsce publishandovsx publishran sequentially in the same step ofbuild-and-test, so a failure in one would skip the other and also skip the GitHub release creation. This PR restructures.github/workflows/on-push.ymlso partial failures are recoverable and obvious:publish-vsceandpublish-ovsxrun independently; a failure in one doesn't block the other.github-releasejob hasif: !cancelled() && needs.package.result == 'success', so a release with notes is produced even if a marketplace publish failed. When that happens, the release body is prepended with a> [!WARNING]admonition naming the failed marketplace(s) and linking to the CI run..vsixartifact. No version bump, no rebuild. (Caveat: the warning banner in the release body is not auto-updated after a successful retry; edit the body by hand if you want it gone.)To avoid gating publishing on the test matrix, the old
build-and-testjob is split into:package— ubuntu-only, builds and packages the extension, uploads the.vsixartifact, and runs the npm workspace publishes.build-and-test(new, keeps the name but not the content) — matrix (Linux + Windows), rebuilds from scratch and runs lint + the VS Code test suite.publish-vsce,publish-ovsx, andgithub-releaseall depend onpackageonly, so tests run in parallel with publishing — matching the pre-existing behavior where tests ran after publish in the old single-job layout. A test failure still marks the workflow red.🤖 Generated with Claude Code