feat: add type-correctness note to rewrite tactic error messages#13368
Draft
Kha wants to merge 1 commit intoleanprover:defeq_todo_4from
Draft
feat: add type-correctness note to rewrite tactic error messages#13368Kha wants to merge 1 commit intoleanprover:defeq_todo_4from
rewrite tactic error messages#13368Kha wants to merge 1 commit intoleanprover:defeq_todo_4from
Conversation
nomeata
reviewed
Apr 10, 2026
src/Lean/Meta/Tactic/Rewrite.lean
Outdated
| check e .instances | ||
| return .nil | ||
| catch _ => | ||
| return m!"\n\nNote: The target expression is not type-correct \ |
Collaborator
There was a problem hiding this comment.
Should this use the .note or .hint combinator?
This PR adds a `transparency` parameter to `Meta.check` (defaulting to `.all` for backwards compatibility) and introduces `withRewriteTypeCheck`, which wraps `rewrite` and lazily checks whether the target expression is type-correct at `instances` transparency when any error occurs. If not, a note is appended to the error message explaining that this can prevent pattern matching.
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 13, 2026
github-actions
bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 13, 2026
mathlib-lean-pr-testing
bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.