feat: use right-associativity in Level.max normalization#13366
Draft
feat: use right-associativity in Level.max normalization#13366
Level.max normalization#13366Conversation
This PR changes the elaborator `Level.normalize` to right-associate `max` expressions, to match `max` notation itself and to match the kernel. It also fixes an issue where simplifiable `imax` expressions would result in unnormalized level expressions (e.g. `(imax (max u v) (max v u)) + 1` would normalize to `(max u v) + 1` instead of `max (u + 1) (v + 1)`).
3 tasks
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 10, 2026
github-actions
bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 10, 2026
mathlib-lean-pr-testing
bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 10, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 10, 2026
|
Mathlib CI status (docs):
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 11, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 11, 2026
|
Mathlib CI status (docs):
|
… simplified decLevel? implementation, add SuccMax approximation, postpone SelfMax further
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 13, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 13, 2026
Collaborator
Author
|
!bench |
|
Benchmark results for 293afe9 against e0a29f4 are in. Significant changes detected! @kmill
Small changes (3✅, 50🟥) Too many entries to display here. View the full report on radar instead. |
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the elaborator
Level.normalizeto right-associatemaxexpressions, to matchmaxnotation itself and to match the kernel. It also fixes an issue where simplifiableimaxexpressions would result in unnormalized level expressions (e.g.(imax (max u v) (max v u)) + 1would normalize to(max u v) + 1instead ofmax (u + 1) (v + 1)).Closes #5695