Skip to content

feat(Data/Set/Basic): add some missing lemmas#35416

Open
joneugster wants to merge 7 commits intoleanprover-community:masterfrom
joneugster:eugster/add_Set.subset_iff
Open

feat(Data/Set/Basic): add some missing lemmas#35416
joneugster wants to merge 7 commits intoleanprover-community:masterfrom
joneugster:eugster/add_Set.subset_iff

Conversation

@joneugster
Copy link
Contributor

This PR continues the work from #22837.

Original PR: #22837

@joneugster
Copy link
Contributor Author

Comments from Original PR #22837

This section contains 1 comment(s) from the original PR, excluding bot comments.


@mathlib-merge-conflicts (2026-02-06 15:21 UTC):
This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Feb 16, 2026
@github-actions
Copy link

PR summary 88bb6d226a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ subset_iff
++ subset_iff_notMem

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@[gcongr] theorem mem_of_subset_of_mem {s₁ s₂ : Set α} {a : α} (h : s₁ ⊆ s₂) : a ∈ s₁ → a ∈ s₂ :=
@h _

theorem subset_iff : s₁ ⊆ s₂ ↔ ∀ ⦃a⦄, a ∈ s₁ → a ∈ s₂ :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of subset_def

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants