Skip to content

feat(NumberTheory/Height/Basic): add {mul|log}Height_comp_le, {mul|log}Height_fun_mul_eq#35408

Open
MichaelStollBayreuth wants to merge 7 commits intoleanprover-community:masterfrom
MichaelStollBayreuth:MS_Heights_7
Open

feat(NumberTheory/Height/Basic): add {mul|log}Height_comp_le, {mul|log}Height_fun_mul_eq#35408
MichaelStollBayreuth wants to merge 7 commits intoleanprover-community:masterfrom
MichaelStollBayreuth:MS_Heights_7

Conversation

@MichaelStollBayreuth
Copy link
Contributor

This adds

  • two missing logHeight lemmas (their mulHeight versions are already there)
  • {mul|log}Height_comp_le: the height of x ∘ f is bounded by the height of x
  • {mul|log}Height_fun_mul_eq: the height of the "multiplication table" fun (i, j) ↦ x i * y j is the {product|sum} of the heights of x and of y
  • {mul|log}Height_fun_prod_eq: the analogous result for products with arbitrarily many factors
  • plus some API lemmas needed for these.

Open in Gitpod

@MichaelStollBayreuth MichaelStollBayreuth added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Feb 16, 2026
@github-actions
Copy link

github-actions bot commented Feb 16, 2026

PR summary d0d33f9830

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ iSup_abv_fun_mul_eq_iSup_abv_mul_iSup_abv
+ iSup_abv_nonneg
+ logHeight_comp_equiv
+ logHeight_comp_le
+ logHeight_fun_mul_eq
+ logHeight_fun_prod_eq
+ logHeight_swap
+ mulHeight_comp_le
+ mulHeight_fun_mul_eq
+ mulHeight_fun_prod_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant