Draft
Conversation
gnavdev28
force-pushed
the
build_llvm23
branch
2 times, most recently
from
a2a7249 to
42711f7
Compare
Contributor
thewilsonator
left a comment
thewilsonator
left a comment
There was a problem hiding this comment.
The commented changes look good with some minor adjustments, please separate them out in to a separate PR that we can merge soon while I continue reviewing.
gnavdev28
force-pushed
the
build_llvm23
branch
2 times, most recently
from
afce095 to
1895c15
Compare
Contributor
|
please rebase |
Contributor
Author
|
@thewilsonator I rebased |
gnavdev28
force-pushed
the
build_llvm23
branch
5 times, most recently
from
bc05f23 to
fb2a2eb
Compare
Contributor
|
PassPlugin.h in drivers/plugins.cpp was moved from llvm/Passes to llvm/Plugins/ since 22.1.0: It looks like the files you have modified haven't include this. |
Contributor
Got it. On windows LDC_ENABLE_PLUGINS is off so you built successfully without modifying plugins.cpp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I am opening this PR to get your help.
I tried to build LDC trunk with the new LLVM 23 on Windows using MSVC. My build method is using CMake and Ninja.
The build failed many times. I just read the error logs and fixed them by instinct (trial and error). To force it to compile, I had to change
gen/ctfloat.cpp,dmd/root/ctfloat.d, andintrinsics.di, etc.Now it builds successfully! However, I know my changes are very messy and I touched the frontend files which I probably shouldn't. (maybe?)
Can you look at my changes and give me some tips on how to fix this the right and clean way?
Thanks!