forked from OpenRadioss/OpenRadioss
-
Notifications
You must be signed in to change notification settings - Fork 0
Optimize ccoor*.F files with array operations and intrinsic functions #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
10
commits into
main
Choose a base branch
from
copilot/optimize-ccoorf-files
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial plan * Fix MPI type inconsistencies in SPMD wrapper functions Co-authored-by: laurent-altr <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: laurent-altr <[email protected]>
…#112) * Initial plan * Fix spmd_wait intent: change request from intent(in) to intent(inout) Co-authored-by: laurent-altr <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: laurent-altr <[email protected]>
* Initial plan * Clean up spmd_wait.F90 - remove duplicate separator lines Co-authored-by: laurent-altr <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: laurent-altr <[email protected]>
* Initial plan * Fix 2D array dimension mismatch in spmd_send.F90 Co-authored-by: laurent-altr <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: laurent-altr <[email protected]>
#118) * Initial plan * Add missing non-MPI fallback paths for scalar allgatherv functions Co-authored-by: laurent-altr <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: laurent-altr <[email protected]>
* Initial plan * Fix 2D array dimension ordering in spmd_recv.F90 to match spmd_send.F90 Co-authored-by: laurent-altr <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: laurent-altr <[email protected]>
* Initial plan * Fix inconsistent local variable declarations in spmd_*pack.F90 Co-authored-by: laurent-altr <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: laurent-altr <[email protected]>
Co-authored-by: laurent-altr <[email protected]>
Co-authored-by: laurent-altr <[email protected]>
Copilot
AI
changed the title
[WIP] Optimize ccoor*F files using intrinsic functions
Optimize ccoor*.F files with array operations and intrinsic functions
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or the bug
The ccoor*.F files contained repetitive hand-coded loops for array assignments and manual distance calculations that could be replaced with more efficient Fortran intrinsics and array operations.
Description of the changes
Replaced hand-coded loops with array slice operations and intrinsic functions across four files:
Array slice operations:
IX1(LFT:LLT)=IXC(2,LFT:LLT)instead of DO loopsDT1C(JFT:JLT)=DT1instead of element-by-element assignmentVL1(I,1:3)=V(1:3,IXCTMP2)instead of 3 separate lines per nodeVL1(I,1:3)=ZEROinstead of 3 separate assignmentsIntrinsic functions:
HYPOT(HYPOT(E3X,E3Y),E3Z)for better numerical accuracyCode cleanup:
Example transformation:
Net reduction: 171 lines → 71 lines (~58% reduction)
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.