Skip to content

Conversation

@joker23
Copy link
Contributor

@joker23 joker23 commented Feb 2, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

SDK-1802

Describe the solution you've provided

  • FDv1 fallback will now always be created
  • fixed contract tests for node server sdk so it will work with latest in feat/fdv2
  • enabled the basic initializer contract test for node server sdk

Note

Medium Risk
Touches core SDK data source construction and fallback behavior, which can affect flag delivery and initialization paths; changes are localized but could impact runtime update behavior if misconfigured.

Overview
Fixes FDv2 initialization so an FDv1 polling fallback synchronizer (/sdk/latest-all) is always added, including when dataSystem.dataSource is custom.

Updates contract-test wiring to match the current feat/fdv2 harness: CI now checks out the branch directly, the contract-test client config now accepts lists of synchronizers/initializers and builds custom DataSourceOptions accordingly, and one FDv2 suppression is removed to re-enable the basic initializer test.

Written by Cursor Bugbot for commit 6864953. This will update automatically on new commits. Configure here.

@joker23 joker23 requested a review from a team as a code owner February 2, 2026 21:56
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25394 bytes
Compressed size limit: 26000
Uncompressed size: 124693 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 171249 bytes
Compressed size limit: 200000
Uncompressed size: 797978 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 18984 bytes
Compressed size limit: 20000
Uncompressed size: 98086 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 23264 bytes
Compressed size limit: 25000
Uncompressed size: 80869 bytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants