fix: Call identify hooks during init.

launchdarkly-android-client-sdk/src/androidTest/java/com/launchdarkly/sdk/android/LDClientHooksTest.java

@@ -61,11 +61,12 @@ public void executesHooksRegisteredDuringConfiguration() throws Exception {
             IdentifySeriesContext identifySeriesContext = new IdentifySeriesContext(newContext, null);
             IdentifySeriesResult identifySeriesResult = new IdentifySeriesResult(IdentifySeriesResult.IdentifySeriesStatus.COMPLETED);
 
-            assertEquals(1, testHook.beforeIdentifyCalls.size());
-            assertEquals(identifySeriesContext, testHook.beforeIdentifyCalls.get(0).get("seriesContext"));
-            assertEquals(1, testHook.afterIdentifyCalls.size());
-            assertEquals(identifySeriesContext, testHook.afterIdentifyCalls.get(0).get("seriesContext"));
-            assertEquals(identifySeriesResult, testHook.afterIdentifyCalls.get(0).get("result"));
+            // index 0 is the implicit identify from init; index 1 is the explicit identify call
+            assertEquals(2, testHook.beforeIdentifyCalls.size());
+            assertEquals(identifySeriesContext, testHook.beforeIdentifyCalls.get(1).get("seriesContext"));
+            assertEquals(2, testHook.afterIdentifyCalls.size());
+            assertEquals(identifySeriesContext, testHook.afterIdentifyCalls.get(1).get("seriesContext"));
+            assertEquals(identifySeriesResult, testHook.afterIdentifyCalls.get(1).get("result"));
 
             ldClient.trackMetric("test-event", LDValue.buildObject().put("data", "test").build(), 123.45);
 
@@ -149,11 +150,12 @@ public void executesBothInitialHooksAndHooksAddedWithAddHooks() throws Exception
             IdentifySeriesContext identifySeriesContext = new IdentifySeriesContext(newContext, null);
             IdentifySeriesResult identifySeriesResult = new IdentifySeriesResult(IdentifySeriesResult.IdentifySeriesStatus.COMPLETED);
 
-            assertEquals(1, testHook.beforeIdentifyCalls.size());
-            assertEquals(identifySeriesContext, testHook.beforeIdentifyCalls.get(0).get("seriesContext"));
-            assertEquals(1, testHook.afterIdentifyCalls.size());
-            assertEquals(identifySeriesContext, testHook.afterIdentifyCalls.get(0).get("seriesContext"));
-            assertEquals(identifySeriesResult, testHook.afterIdentifyCalls.get(0).get("result"));
+            // index 0 is the implicit identify from init; index 1 is the explicit identify call
+            assertEquals(2, testHook.beforeIdentifyCalls.size());
+            assertEquals(identifySeriesContext, testHook.beforeIdentifyCalls.get(1).get("seriesContext"));
+            assertEquals(2, testHook.afterIdentifyCalls.size());
+            assertEquals(identifySeriesContext, testHook.afterIdentifyCalls.get(1).get("seriesContext"));
+            assertEquals(identifySeriesResult, testHook.afterIdentifyCalls.get(1).get("result"));
 
             assertEquals(1, addedHook.beforeIdentifyCalls.size());
             assertEquals(identifySeriesContext, addedHook.beforeIdentifyCalls.get(0).get("seriesContext"));

launchdarkly-android-client-sdk/src/androidTest/java/com/launchdarkly/sdk/android/LDClientPluginsTest.java

@@ -51,6 +51,9 @@ public void registerIsCalledForPlugins() throws Exception {
         MockPlugin testPlugin = new MockPlugin(Collections.singletonList(testHook));
 
         try (LDClient ldClient = LDClient.init(application, makeOfflineConfig(List.of(testPlugin)), ldContext, 1)) {
+            // This should get called because of an implicit identity.
+            assertEquals(1, testHook.beforeIdentifyCalls.size());
+
             ldClient.boolVariation("test-flag", false);
             assertEquals(1, testPlugin.getHooksCalls.size());
             assertEquals(1, testPlugin.registerCalls.size());
@@ -119,6 +122,59 @@ public void pluginRegisterCalledForEachClientEnvironment() throws Exception {
         }
     }
 
+    @Test
+    public void identifyHooksRunForEachEnvironment() throws Exception {
+        MockHook testHook = new MockHook();
+        MockPlugin testPlugin = new MockPlugin(Collections.singletonList(testHook));
+
+        LDConfig config = new LDConfig.Builder(LDConfig.Builder.AutoEnvAttributes.Disabled)
+                .mobileKey(mobileKey)
+                .secondaryMobileKeys(Map.of("secondaryEnvironment", secondaryMobileKey))
+                .plugins(Components.plugins().setPlugins(Collections.singletonList(testPlugin)))
+                .offline(true)
+                .events(Components.noEvents())
+                .logAdapter(logging.logAdapter)
+                .build();
+
+        try (LDClient ldClient = LDClient.init(application, config, ldContext, 10)) {
+            IdentifySeriesContext initCtx = new IdentifySeriesContext(ldContext, null);
+            IdentifySeriesResult completedResult = new IdentifySeriesResult(IdentifySeriesResult.IdentifySeriesStatus.COMPLETED);
+
+            // After init: implicit identify fires once per instance (primary + secondary)
+            assertEquals(2, testHook.beforeIdentifyCalls.size());
+            assertEquals(initCtx, testHook.beforeIdentifyCalls.get(0).get("seriesContext"));
+            assertEquals(initCtx, testHook.beforeIdentifyCalls.get(1).get("seriesContext"));
+            assertEquals(2, testHook.afterIdentifyCalls.size());
+            assertEquals(initCtx, testHook.afterIdentifyCalls.get(0).get("seriesContext"));
+            assertEquals(completedResult, testHook.afterIdentifyCalls.get(0).get("result"));
+            assertEquals(initCtx, testHook.afterIdentifyCalls.get(1).get("seriesContext"));
+            assertEquals(completedResult, testHook.afterIdentifyCalls.get(1).get("result"));
+
+            LDContext newContext = LDContext.create("newUserKey");
+            IdentifySeriesContext newCtx = new IdentifySeriesContext(newContext, null);
+            ldClient.identify(newContext).get();
+
+            // After identifying on the primary client: +1
+            assertEquals(3, testHook.beforeIdentifyCalls.size());
+            assertEquals(newCtx, testHook.beforeIdentifyCalls.get(2).get("seriesContext"));
+            assertEquals(3, testHook.afterIdentifyCalls.size());
+            assertEquals(newCtx, testHook.afterIdentifyCalls.get(2).get("seriesContext"));
+            assertEquals(completedResult, testHook.afterIdentifyCalls.get(2).get("result"));
+
+            LDClient.getForMobileKey("secondaryEnvironment").identify(newContext).get();
+
+            // After identifying on the secondary client: +1
+            assertEquals(4, testHook.beforeIdentifyCalls.size());
+            assertEquals(newCtx, testHook.beforeIdentifyCalls.get(3).get("seriesContext"));
+            assertEquals(4, testHook.afterIdentifyCalls.size());
+            assertEquals(newCtx, testHook.afterIdentifyCalls.get(3).get("seriesContext"));
+            assertEquals(completedResult, testHook.afterIdentifyCalls.get(3).get("result"));
+
+            logging.assertNoWarningsLogged();
+            logging.assertNoErrorsLogged();
+        }
+    }
+
     private LDConfig makeOfflineConfig(List<Plugin> plugins) {
         LDConfig.Builder builder = new LDConfig.Builder(LDConfig.Builder.AutoEnvAttributes.Disabled)
                 .mobileKey(mobileKey)

launchdarkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/LDClient.java

@@ -249,23 +249,32 @@ public static Future<LDClient> init(@NonNull Application application,
         }
 
         final AtomicInteger initCounter = new AtomicInteger(config.getMobileKeys().size());
-        Callback<Void> completeWhenCounterZero = new Callback<Void>() {
+        class CompleteWhenCounterZero implements Callback<Void> {
+            final private HookRunner.AfterIdentifyMethod afterIdentify;
+
+            CompleteWhenCounterZero(HookRunner.AfterIdentifyMethod afterIdentify) {
+                this.afterIdentify = afterIdentify;
+            }
+
             @Override
             public void onSuccess(Void result) {
+                afterIdentify.invoke(new IdentifySeriesResult(IdentifySeriesResult.IdentifySeriesStatus.COMPLETED));
                 if (initCounter.decrementAndGet() == 0) {
                     resultFuture.set(primaryClient);
                 }
             }
 
             @Override
             public void onError(Throwable e) {
+                afterIdentify.invoke(new IdentifySeriesResult(IdentifySeriesResult.IdentifySeriesStatus.ERROR));
                 resultFuture.setException(e);
             }
         };
 
         // Start up all instances
         for (final LDClient instance : instances.values()) {
-            if (instance.connectivityManager.startUp(completeWhenCounterZero)) {
+            HookRunner.AfterIdentifyMethod afterIdentify = instance.hookRunner.identify(modifiedContext, null);
+            if (instance.connectivityManager.startUp(new CompleteWhenCounterZero(afterIdentify))) {
                 instance.eventProcessor.recordIdentifyEvent(modifiedContext);
             }
         }