-
Notifications
You must be signed in to change notification settings - Fork 127
Migrate jwcrypto packaging to Hatch #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
simo5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like the 1st, 2nd and 4th commit should be squashed, and code changed to just import the version file.
|
I also do not see removal of setup.py here, should this PR marked as draft until all objectives are reached? |
|
At the moment I’m keeping both setup.py and Hatch support to ensure a smooth transition. setup.py will be fully removed in a future PR. |
simo5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
the only thing I notice is that the first commit will not work w/o the second so may as well just squash them
I’ve squashed the two dependent commits into a single one, as suggested. |
|
TBH I do not remember what this file is used for, but VERSION is also referenced in MANIFEST.in and would need to be changed as well. Otherwise PR is good. |
and remove setup.py-based build configuration Replace VERSION file with version.py for version metadata Refactor setup.py to read version from python source instead of plain file Replace VERSION file with version.py for version metadata in docs import version directly from jwcrypto.version in conf.py v s
|
I've removed the VERSION reference from MANIFEST.in since it's no longer needed with dynamic versioning.Changes pushed |
|
Thanks for the contribution! |
This PR migrates the project packaging from setuptools to Hatch, by introducing a complete
pyproject.tomlconfiguration and removing the legacysetup.py+VERSIONfile approach.pyproject.tomlwith project metadata, dependencies, license, classifiers etc.jwcrypto/version.py.jwcrypto/VERSIONfiles.Closes #304