Skip to content

revert: "feat: add uv sync offline flag (#624)" and "fix: fix uv offline set position (#644)"#651

Open
kurokobo wants to merge 2 commits intolanggenius:mainfrom
kurokobo:offline
Open

revert: "feat: add uv sync offline flag (#624)" and "fix: fix uv offline set position (#644)"#651
kurokobo wants to merge 2 commits intolanggenius:mainfrom
kurokobo:offline

Conversation

@kurokobo
Copy link
Contributor

Description

Closes #649

This PR reverts following two PRs to support --offline switch for uv sync command.

There was an issue with #624 and #644 where, regardless of the installation method, uv sync --offline would always be attempted for all plugins that have a pyproject.toml file, causing even regular installations from the marketplace to fail.

We will revert these two PRs.
Instead, by creating a difypkg file for offline installation as follows, users can install plugins offline.

With this, the Plugin Daemon can support offline installation for difypkg without any special implementation.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 20, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses critical issues with uv sync --offline functionality by reverting two previous changes that inadvertently broke regular plugin installations. It introduces a more robust and flexible approach for offline plugin installation, enabling users to install plugins offline via difypkg files with specific configuration, thereby simplifying the Plugin Daemon's internal logic and improving overall stability.

Highlights

  • Reverted Previous Changes: Two prior pull requests (feat: add uv sync offline flag #624 and fix: fix uv offline set position #644) that introduced uv sync --offline functionality were reverted.
  • Addressed Installation Failures: The previous implementation caused uv sync --offline to fail for regular marketplace installations when pyproject.toml was present.
  • New Offline Installation Strategy: A new method for offline plugin installation is introduced, leveraging difypkg files and specific configurations (--no-index, --find-links) within pyproject.toml or requirements.txt.
  • Simplified Plugin Daemon: The Plugin Daemon no longer requires special implementation to support offline installation for difypkg.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts two previous features that added an --offline flag to the uv sync command. The changes correctly remove the logic for adding this flag, along with associated helper functions, caching mechanisms, and tests. This aligns with the goal of handling offline installations outside of the plugin daemon as described.

I've added one comment regarding the removal of godotenv, which seems unrelated to the revert and could impact local development setups. Otherwise, the revert is implemented correctly.

@dosubot dosubot bot added bug Something isn't working go Pull requests that update go code plugin-daemon labels Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update go code plugin-daemon size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-Opened: Can’t install plugins from either local packages or the marketplace.

1 participant