revert: "feat: add uv sync offline flag (#624)" and "fix: fix uv offline set position (#644)"#651
revert: "feat: add uv sync offline flag (#624)" and "fix: fix uv offline set position (#644)"#651kurokobo wants to merge 2 commits intolanggenius:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical issues with Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts two previous features that added an --offline flag to the uv sync command. The changes correctly remove the logic for adding this flag, along with associated helper functions, caching mechanisms, and tests. This aligns with the goal of handling offline installations outside of the plugin daemon as described.
I've added one comment regarding the removal of godotenv, which seems unrelated to the revert and could impact local development setups. Otherwise, the revert is implemented correctly.
Description
Closes #649
This PR reverts following two PRs to support
--offlineswitch foruv synccommand.There was an issue with #624 and #644 where, regardless of the installation method,
uv sync --offlinewould always be attempted for all plugins that have apyproject.tomlfile, causing even regular installations from the marketplace to fail.We will revert these two PRs.
Instead, by creating a
difypkgfile for offline installation as follows, users can install plugins offline.pyproject.toml, addno-indexandfind-linksunder[tool.uv]in the file (see feat: support uv to download package junjiem/dify-plugin-repackaging#60 (comment))requirements.txt, just as current implementation of re-packager, add--no-indexand--find-linksas the first lines of the fileWith this, the Plugin Daemon can support offline installation for difypkg without any special implementation.
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information