fix: improve error handling for environment variable parsing #5560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuQianJin-Stars
force-pushed
the
fix/env-var-parsing-error-handling
branch
from
aeb086d to
9f91118
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
XuQianJin-Stars
force-pushed
the
fix/env-var-parsing-error-handling
branch
from
9f91118 to
24657a1
Compare
XuQianJin-Stars
force-pushed
the
fix/env-var-parsing-error-handling
branch
from
24657a1 to
66eab2e
Compare
yanghua
reviewed
Dec 26, 2025
rust/lance/src/dataset/scanner.rs
Outdated
| Ok(value) => Some(value), | ||
| Err(e) => { | ||
| log::warn!( | ||
| "Failed to parse {}='{}': {}. {}", |
Collaborator
There was a problem hiding this comment.
Failed to parse the environment variable {}='{}': {}, the default value is: {}.
rust/lance/src/dataset/scanner.rs
Outdated
| pub(crate) const BATCH_SIZE_FALLBACK: usize = 8192; | ||
|
|
||
| /// Parse an environment variable as a specific type, logging a warning on parse failure. | ||
| fn parse_env_var<T: std::str::FromStr>(env_var_name: &str, default_hint: &str) -> Option<T> |
Collaborator
There was a problem hiding this comment.
default_hint -> default_val?
yanghua
reviewed
Dec 26, 2025
| std::env::var("LANCE_DEFAULT_BATCH_SIZE") | ||
| .map(|val| Some(val.parse().unwrap())) | ||
| .unwrap_or(None) | ||
| parse_env_var("LANCE_DEFAULT_BATCH_SIZE", "Using default.") |
Collaborator
There was a problem hiding this comment.
IMO, here the second parameter we can just pass the string representing the value. WDYT?
yanghua
reviewed
Dec 26, 2025
| .unwrap_or(None) | ||
| }); | ||
| pub static DEFAULT_FRAGMENT_READAHEAD: LazyLock<Option<usize>> = | ||
| LazyLock::new(|| parse_env_var("LANCE_DEFAULT_FRAGMENT_READAHEAD", "Using default.")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace unwrap() calls with proper error handling in environment variable parsing functions to prevent panics when invalid values are provided.
Changes:
When parsing fails, the functions now:
Added test_env_var_parsing() to verify the new error handling behavior.