chore: lower jvm glibc to 22.04 #3737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chebbyChefNEQ
requested review from
Copilot,
eddyxu,
jackye1995,
jmhsieh,
westonpace and
wjones127
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Ubuntu version used in GitHub workflows to Ubuntu 20.04 to improve glibc compatibility. The key changes include:
- Updating the "rust-clippy-fmt" job to use ubuntu-20.04.
- Updating the "build-and-test-java" job to use ubuntu-20.04.
- Updating the "linux-x86" job in the java-publish workflow to use ubuntu-20.04.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/java.yml | Changed two job environments from ubuntu-24.04 to ubuntu-20.04 |
| .github/workflows/java-publish.yml | Changed linux-x86 job environment from ubuntu-24.04 to ubuntu-20.04 |
chebbyChefNEQ
force-pushed
the
rmeng/jvm-glib
branch
from
a5b482c to
a9c0af3
Compare
chebbyChefNEQ
changed the title
eddyxu
approved these changes
Apr 24, 2025
westonpace
approved these changes
Apr 24, 2025
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Yeah, I think to get to 20.04 we'd have to run a docker-based build (but that might not be too hard).
jackye1995
approved these changes
Apr 24, 2025
chebbyChefNEQ
force-pushed
the
rmeng/jvm-glib
branch
from
a9c0af3 to
9ec7639
Compare
Contributor
|
Added docker build for java publishing in #3703, but that PR continues to use 24.04 for testing. The publishing workflow also uses 24.04 as the base runner and only uses docker to run the build steps in 20.04. We can continue to evaluate if we want to switch everything to 22.04 here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lower to ubuntu 22.04 to get better glibc compatibility