Skip to content

spec: update names for error responses to be consistent #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackye1995 merged 2 commits into from
Apr 23, 2025
Merged

spec: update names for error responses to be consistent #54

jackye1995 merged 2 commits into from
Apr 23, 2025

Conversation

@jackye1995
Copy link
Collaborator

@jackye1995 jackye1995 commented Apr 22, 2025 •
edited
Loading

Rename ErrorModel to ErrorResponse to be consistent with other response schema models that also ends with Response

Make sure all the error responses end with ErrorResponse

@github-actions github-actions bot added chore Features related to test, build, style improvements python Python features java Java features spec Restful openapi spec rust Rust features labels Apr 22, 2025
@jackye1995 jackye1995 changed the title chore: update names for error responses to be consistent spec: update names for error responses to be consistent Apr 22, 2025
@github-actions github-actions bot added the enhancement New feature or request label Apr 22, 2025
@jackye1995 jackye1995 requested a review from yanghua April 22, 2025 22:12
@jackye1995 jackye1995 merged commit 144ea01 into lance-format:main Apr 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanghua yanghua yanghua approved these changes

Assignees

No one assigned

Labels

chore Features related to test, build, style improvements enhancement New feature or request java Java features python Python features rust Rust features spec Restful openapi spec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackye1995 @yanghua