Skip to content

Conversation

@ChunxuTang
Copy link
Collaborator

@ChunxuTang ChunxuTang commented Dec 5, 2025

This PR unifies Python/Rust execute and explain APIs and updates tests accordingly.

Python:

  • execute(datasets, execution_strategy)
  • explain(datasets)
  • removed execute_datafusion and explain_datafusion

Rust:

  • execute(datasets, execution_strategy): DataFusion (default), Simple, LanceNative (not yet implemented)
  • explain(datasets): use datafusion planner to generate the plans
  • execute_with_context(session_context)
  • execute_with_catalog_and_context(catalog, session_context)

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@ChunxuTang ChunxuTang changed the title Unify the execute and explain APIs feat: Unify the execute and explain APIs Dec 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-graph/src/query.rs 80.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ChunxuTang ChunxuTang requested a review from beinan December 5, 2025 03:09
@beinan beinan merged commit c7a4650 into lance-format:main Dec 5, 2025
9 checks passed
@ChunxuTang ChunxuTang deleted the api branch December 27, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants