Skip to content

Conversation

@ChunxuTang
Copy link
Collaborator

This PR adds the support of joins between two disconnected patterns.

The join type and keys are determined by:

  • Cross joins: No join conditions needed
  • Other joins: Infer join keys from shared variables between patterns

The implementation of relationship variable join key generation is left as a TODO now.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 82.85024% with 71 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@c27809a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
rust/lance-graph/src/datafusion_planner/builder.rs 82.85% 71 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage        ?   81.92%           
=======================================
  Files           ?       23           
  Lines           ?     8258           
  Branches        ?        0           
=======================================
  Hits            ?     6765           
  Misses          ?     1493           
  Partials        ?        0           
Flag Coverage Δ
rust-unittests 81.92% <82.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beinan beinan merged commit cc936e6 into lance-format:main Nov 9, 2025
9 checks passed
@ChunxuTang ChunxuTang deleted the join branch November 16, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants