Architecture Sniffer V2 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for PHPIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
zibellino
reviewed
Aug 14, 2025
Kununu/ArchitectureSniffer/Configuration/Selector/SelectableCollection.php
Outdated
Show resolved
Hide resolved
zibellino
reviewed
Aug 14, 2025
Kununu/ArchitectureSniffer/Configuration/Selector/SelectableCollection.php
Outdated
Show resolved
Hide resolved
zibellino
reviewed
Aug 14, 2025
Contributor
|
Otherwise looks good. A default/example |
zibellino
reviewed
Aug 21, 2025
Kununu/ArchitectureSniffer/Configuration/Rules/AbstractRule.php
Outdated
Show resolved
Hide resolved
zibellino
reviewed
Aug 21, 2025
zibellino
reviewed
Aug 21, 2025
zibellino
reviewed
Aug 21, 2025
Kununu/ArchitectureSniffer/Configuration/ArchitectureLibrary.php
Outdated
Show resolved
Hide resolved
zibellino
reviewed
Aug 21, 2025
Kununu/ArchitectureSniffer/Configuration/ArchitectureLibrary.php
Outdated
Show resolved
Hide resolved
zibellino
approved these changes
Aug 21, 2025
Contributor
zibellino
left a comment
zibellino
left a comment
There was a problem hiding this comment.
Apart from the comments it looks good.
CarlosGRodriguezL
added a commit
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.