-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🐛 fix(cli): format version subcommand output #5236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
🐛 fix(cli): format version subcommand output #5236
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vitorfloriano The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @vitorfloriano. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5d77665 to
ae97bbf
Compare
|
Hi @camilamacedo86 hope you're doing well. I opened helm/helm#31574 to fix a similar issue and was informed by the Helm maintainers that formating the I'm not sure if any other programs are consuming the output from |
ae97bbf to
eceb6f1
Compare
eceb6f1 to
3a13b53
Compare
The version subcommand now displays the version info in a human-readable table format.
3a13b53 to
fdd6232
Compare
Thanks for working on this — the new output is much nicer for humans 👍 I think we can move forward if we add a minimal stable output format, for example: and keep the pretty output as the default. This gives tooling a stable contract while improving the human UX. |
This PR changes the
versionsubcommand output to a human-readable table format: