Add conversion webhook for v1#947
Conversation
✅ Deploy Preview for kubernetes-sigs-jobset ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: imreddy13 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @imreddy13. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XXL
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| @@ -0,0 +1,21 @@ | |||
| /* | |||
| Copyright 2023 The Kubernetes Authors. | |||
There was a problem hiding this comment.
| Copyright 2023 The Kubernetes Authors. | |
| Copyright 2025 The Kubernetes Authors. |
| @@ -0,0 +1,420 @@ | |||
| /* | |||
There was a problem hiding this comment.
Thank you for driving this @imreddy13!
Can we discuss all of the breaking changes to the JobSet APIs before introducing the V1 please ?
I feel like we have a few open discussions that we need to resolve before the v1, for example:
- Remove StartupPolicy API in favour of DependsOn
- Rename JobSet status to Complete #723
- Make ReplicatedJobs a custom resource with their own controller #946
There was a problem hiding this comment.
#946 Would involve a significant refactor/rewrite of much of the codebase, so it could probably wait til v2 as @GiuseppeTT pointed out.
There was a problem hiding this comment.
Shall we consider to have v1alpha2 API before the v1 API to deprecate several APIs ?
There was a problem hiding this comment.
That makes sense.
My only recommendation is that we maintain consistency across JobSet status fields.
Which means if we maintain ReplicatedJobsStatus field, keep the IndividualJobsStatus field, where we define:
type IndividualJobStatus struct {
Name string `json:"name"`
Recreates int32 `json:"recreates"`
}There was a problem hiding this comment.
I agree with that. @carreter would you be up for making that change?
There was a problem hiding this comment.
I think we can do this in v1alpha2 since we did not yet release this change.
There was a problem hiding this comment.
I agree with that. @carreter would you be up for making that change?
Sure, I'll take a stab at it! Makes sense to try and keep it consistent.
|
/hold You mentioned this is still a draft offline. |
k8s-ci-robot
added
the
do-not-merge/hold
|
cc @tchap @ardaguclu I mentioned this work to you all so just wanted you to be aware. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
@imreddy13: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?