Add support for custom annotations in JobSet controller

[dabico]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow users to specify custom annotations for the JobSet controller deployment and individual pods. This is useful, for example, when you already have Prometheus deployed to your cluster and would like to scrape metrics.

Does this PR introduce a user-facing change?

Add support for specifying custom `annotations` for JobSet controller deployment and pods via `controller.annotations` and `controller.podAnnotations` Helm values respectively.

[netlify]

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name	Link
🔨 Latest commit	db81cbd
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-jobset/deploys/699263c58ba7a70008d95175

[k8s-ci-robot]

Welcome @dabico!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @dabico. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Copilot]

Pull request overview

This PR adds support for custom annotations on the JobSet controller pods, enabling users to configure pod-level annotations such as those needed for Prometheus metric scraping. The change introduces a new controller.annotations field in the Helm chart values that gets applied to the Pod template.

Changes:

• Added controller.annotations configuration field in values.yaml with empty object default
• Updated deployment template to include custom annotations in the Pod template metadata
• Updated README.md documentation to reflect the new configuration option

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
charts/jobset/values.yaml	Adds controller.annotations field with documentation and default empty object value
charts/jobset/templates/controller/deployment.yaml	Applies custom annotations to Pod template metadata alongside existing config-hash annotation
charts/jobset/README.md	Documents the new controller.annotations configuration option in the values table

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[kannon92]

Can you add some helm unit tests for this also?

[kannon92]

/ok-to-test

[kannon92]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dabico, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kannon92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kannon92]

/hold

Can you add a release note for this actually?

[dabico]

Can you add a release note for this actually?

Done! Updated the PR description.

[kannon92]

/hold cancel

Thank you for this!