Update sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.1

[GiuseppeTT]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.1 . The automatic bump #1145 did not work because version 0.23 introduced breaking changes. See https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.23.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This PR uses the original commit a840be090c3668adeff13fab36c05d855dceb992 from #1145 and creates a second commit 8538d318fa71909e8dccd5d30afd07725444d91d to fix the breaking changes.

Does this PR introduce a user-facing change?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GiuseppeTT

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [GiuseppeTT]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name	Link
🔨 Latest commit	8538d31
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-jobset/deploys/6980e450df7c9a0008a1dcf9

[GiuseppeTT]

/assign @andreyvelich since he has context.

[k8s-ci-robot]

@GiuseppeTT: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-jobset-verify-main	8538d31	link	true	/test pull-jobset-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[GiuseppeTT]

GetEventRecorderFor is being deprecated. Let me see what I can do.

Failed test

golangci/golangci-lint info installed ./bin/golangci-lint
/home/prow/go/src/sigs.k8s.io/jobset/bin/golangci-lint run --timeout 15m0s
main.go:237:88: SA1019: mgr.GetEventRecorderFor is deprecated: this uses the old events API and will be removed in a future release. Please use GetEventRecorder instead. (staticcheck)
	jobSetController := controllers.NewJobSetReconciler(mgr.GetClient(), mgr.GetScheme(), mgr.GetEventRecorderFor("jobset"))
	                                                                                      ^
main.go:244:82: SA1019: mgr.GetEventRecorderFor is deprecated: this uses the old events API and will be removed in a future release. Please use GetEventRecorder instead. (staticcheck)
	podController := controllers.NewPodReconciler(mgr.GetClient(), mgr.GetScheme(), mgr.GetEventRecorderFor("pod"))
	                                                                                ^
test/integration/controller/suite_test.go:89:102: SA1019: k8sManager.GetEventRecorderFor is deprecated: this uses the old events API and will be removed in a future release. Please use GetEventRecorder instead. (staticcheck)
	jobSetReconciler := controllers.NewJobSetReconciler(k8sManager.GetClient(), k8sManager.GetScheme(), k8sManager.GetEventRecorderFor("jobset"))
	                                                                                                    ^
test/integration/controller/suite_test.go:98:96: SA1019: k8sManager.GetEventRecorderFor is deprecated: this uses the old events API and will be removed in a future release. Please use GetEventRecorder instead. (staticcheck)
	podReconciler := controllers.NewPodReconciler(k8sManager.GetClient(), k8sManager.GetScheme(), k8sManager.GetEventRecorderFor("pod"))
	                                                                                              ^
4 issues:
* staticcheck: 4
make: *** [Makefile:154: ci-lint] Error 1
+ EXIT_VALUE=2
+ set +o xtrace
Cleaning up after docker in docker.

[kannon92]

GetEventRecorderFor is being deprecated. Let me see what I can do.

Failed test

golangci/golangci-lint info installed ./bin/golangci-lint
/home/prow/go/src/sigs.k8s.io/jobset/bin/golangci-lint run --timeout 15m0s
main.go:237:88: SA1019: mgr.GetEventRecorderFor is deprecated: this uses the old events API and will be removed in a future release. Please use GetEventRecorder instead. (staticcheck)
	jobSetController := controllers.NewJobSetReconciler(mgr.GetClient(), mgr.GetScheme(), mgr.GetEventRecorderFor("jobset"))
	                                                                                      ^
main.go:244:82: SA1019: mgr.GetEventRecorderFor is deprecated: this uses the old events API and will be removed in a future release. Please use GetEventRecorder instead. (staticcheck)
	podController := controllers.NewPodReconciler(mgr.GetClient(), mgr.GetScheme(), mgr.GetEventRecorderFor("pod"))
	                                                                                ^
test/integration/controller/suite_test.go:89:102: SA1019: k8sManager.GetEventRecorderFor is deprecated: this uses the old events API and will be removed in a future release. Please use GetEventRecorder instead. (staticcheck)
	jobSetReconciler := controllers.NewJobSetReconciler(k8sManager.GetClient(), k8sManager.GetScheme(), k8sManager.GetEventRecorderFor("jobset"))
	                                                                                                    ^
test/integration/controller/suite_test.go:98:96: SA1019: k8sManager.GetEventRecorderFor is deprecated: this uses the old events API and will be removed in a future release. Please use GetEventRecorder instead. (staticcheck)
	podReconciler := controllers.NewPodReconciler(k8sManager.GetClient(), k8sManager.GetScheme(), k8sManager.GetEventRecorderFor("pod"))
	                                                                                              ^
4 issues:
* staticcheck: 4
make: *** [Makefile:154: ci-lint] Error 1
+ EXIT_VALUE=2
+ set +o xtrace
Cleaning up after docker in docker.

Could this PR solve this? #1119

[GiuseppeTT]

Probably related to #1119

[GiuseppeTT]

Could this PR solve this? #1119

I think so.

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.