🐛 Return error when object limit exceeded for cached list calls

[chhsia0]

Since the cache does not implement strongly consistent paginated list calls, if the Limit option is set and the number of items listed exceeds this limit, there is no way for the caller to get a complete list of objects, so return an error here to notify the caller.

Fixes #3044.

[k8s-ci-robot]

Welcome @chhsia0!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chhsia0
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @chhsia0. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alvaroaleman]

/hold

This is a breaking change and breaks the use-case "Check if there are any objects of a given type". I agree the current behavior is subpar, but the new behavior would also be subpar but different and a breaking change so I am not in favor of merging this.

Alternate approaches:

1. Add support for this into the upstream informer
2. Return some sort of sentinel continue token and error out if it is used

[sbueringer]

I think we can implement option 2. Or at least I don't see any downsides.

It should reduce accidental usage of pagination

[sbueringer]

/close
in favor of #3134

[k8s-ci-robot]

@sbueringer: Closed this PR.

Details

In response to this:

/close
in favor of #3134

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.