WIP: tests: implement non-blocking watch#318
Open
justinsb wants to merge 2 commits intokubernetes-sigs:mainfrom
Open
WIP: tests: implement non-blocking watch#318justinsb wants to merge 2 commits intokubernetes-sigs:mainfrom
justinsb wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
This lets us set up watches in advance and reuse them across multiple checks, so we can avoid the overhead of setting up watches every time. This gives more accurate metrics and lets us easily collect more metrics, in particular around pod creation latency.
k8s-ci-robot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for agent-sandbox canceled.
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
This was referenced Feb 14, 2026
A naive implementation of channels blocks when the channel is full. We can move to a more "classical" approach of a mutex and condition, though we still have to implemnent the condition using a channel, because Go doesn't have a condition that supports context-aware waiting.
justinsb
force-pushed
the
nonblocking_watchset
branch
from
55cfe58 to
b019c11
Compare
Contributor
Author
|
I think I prefer #319 |
k8s-ci-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A naive implementation of channels blocks when the channel is full.
We can move to a more "classical" approach of a mutex and condition,
though we still have to implemnent the condition using a channel,
because Go doesn't have a condition that supports context-aware waiting.