Skip to content

chore: fix the line wrapping in ruamel.yaml#986

Open
christian-heusel wants to merge 1 commit intokubeflow:notebooks-v1from
christian-heusel:chore/fix-line-wrapping-ruamel
Open

chore: fix the line wrapping in ruamel.yaml#986
christian-heusel wants to merge 1 commit intokubeflow:notebooks-v1from
christian-heusel:chore/fix-line-wrapping-ruamel

Conversation

@christian-heusel
Copy link
Copy Markdown
Contributor

So far the library has caused line wraps when the version used is
(some version) greater than 18.11, which annoyed Mathew when doing
releases. Fix this by setting a really high value for maximum line
length.

This causes diffs like the following:

-    value: ghcr.io/kubeflow/kubeflow/notebook-servers/codeserver-python:latest
+    value:
+      ghcr.io/kubeflow/kubeflow/notebook-servers/codeserver-python:v1.11.0-rc.

So far the library has caused line wraps when the version used is
(some version) greater than 18.11, which annoyed Mathew when doing
releases. Fix this by setting a really high value for maximum line
length.

Signed-off-by: Christian Heusel <christian@heusel.eu>
@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Mar 24, 2026
@google-oss-prow google-oss-prow bot requested a review from kimwnasptd March 24, 2026 22:06
@google-oss-prow google-oss-prow bot added the area/release area - related to releasing label Mar 24, 2026
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added area/v1 area - version - kubeflow notebooks v1 size/XS labels Mar 24, 2026
@christian-heusel
Copy link
Copy Markdown
Contributor Author

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release area - related to releasing area/v1 area - version - kubeflow notebooks v1 ok-to-test size/XS

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

1 participant