-
-
Notifications
You must be signed in to change notification settings - Fork 156
Feature/UI core split #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/UI core split #97
Conversation
|
@MartinColja I love it |
|
@krzysztofzablocki sorry for taking so long. I've only worked with SPM so far, so it took me a bit to figure everything out. 😅 CocoapodsI decided to create two CarthageTo support Carthage, I created a new Also, I wasn't able to add this framework as a dependency with Carthage, so I still think this is an improvement, even though it isn't visible from Objective-C. IssuesAnother thing I wasn't able to achieve was keeping the Objective-C source from breaking after this separation. Because of that, it will be necessary to write Please let me know if you think these issues are worth this split, and if not, what issues I should address. Also, I'm open to suggestions if you have any ideas on how to fix or work around these issues. Finally, I don't know if there is any additional housekeeping that I should do before this is ready to be merged. I increased the version in the specs to |
|
Hey @krzysztofzablocki, we wanted to check in with you about this PR. Is this something you are still interested in? |
|
I like this, I think you can just loose objective c compatibility to make things easier and do major version bump, people can still use old version with objc |
|
@krzysztofzablocki that sounds good! Just an fyi regarding timelines, I can make these adjustments after I free up some of my work queue, hopefully by the end of the month |
|
Sounds good |
I’d love to use this library in my project, but I don’t want to pull in the whole UI package since I’m also supporting macOS. This would enable easier integration with other tools, and people might prefer integration without UI. If the library were split into smaller parts, people could pick and choose what they need.
This is just a draft for now because I still need to implement support for CocoaPods and Carthage. But before I go further, I want to see what you think about this idea.