Skip to content

fix(circom): handle case when parts dont exist #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chokobole merged 1 commit into from
Nov 29, 2024
Merged

fix(circom): handle case when parts dont exist #558

chokobole merged 1 commit into from
Nov 29, 2024
+1 −1

Conversation

@batzor
Copy link
Contributor

@batzor batzor commented Nov 29, 2024

Description

This PR fixes unhandled case in #557 :(

chokobole
chokobole approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fakedev9999
fakedev9999 approved these changes Nov 29, 2024
View reviewed changes
Copy link

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashjeong
ashjeong approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit e7b1306 into main Nov 29, 2024
5 checks passed
@chokobole chokobole deleted the fix/witness_generator_tool_bug branch November 29, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongchangYoo dongchangYoo Awaiting requested review from dongchangYoo

3 more reviewers

@chokobole chokobole chokobole approved these changes

@fakedev9999 fakedev9999 fakedev9999 approved these changes

@ashjeong ashjeong ashjeong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@batzor @chokobole @fakedev9999 @ashjeong