Skip to content

Conversation

@shawn-hurley
Copy link
Contributor

@shawn-hurley shawn-hurley commented Jan 8, 2026

This also fixes an issue with the test dockerfile to use the updated jdtls

Summary by CodeRabbit

  • Chores
    • Updated JDTLS to version 1.51.0 with improved tar extraction handling.
    • Updated Apache Maven to version 3.9.12.
    • Updated build environment configuration accordingly.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

Updated test Dockerfile dependencies: JDTLS from 1.38.0 to 1.51.0, Apache Maven from 3.9.11 to 3.9.12, and added --no-same-permissions flag during tar extraction. Updated corresponding path references and M2_HOME environment variable.

Changes

Cohort / File(s) Summary
Docker test configuration
Dockerfile.test
Updated JDTLS version (1.38.0 → 1.51.0) with added --no-same-permissions tar extraction flag; updated Maven version (3.9.11 → 3.9.12) and symlink path; updated M2_HOME variable accordingly

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 The tools grow stronger, versions rise,
From 1.38 to 1.51 skies,
Maven steps forward, 3.9.12 in sight,
Permissions preserved, Docker takes flight! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions triggering a Java provider build after image build completion, but the actual changes only update JDTLS and Maven versions in the test Dockerfile with no visible build trigger logic. Verify that the PR includes changes related to the build trigger mechanism. If changes are missing, clarify whether the title accurately reflects the actual changeset or if additional commits are needed.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a3a975 and 110d5fc.

📒 Files selected for processing (1)
  • Dockerfile.test
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile.test
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: JDT.LS Integration Tests (Phase 2)
  • GitHub Check: image-build / build (arm64)
  • GitHub Check: image-build / build (s390x)
  • GitHub Check: image-build / build (ppc64le)
  • GitHub Check: image-build / build (amd64)
  • GitHub Check: Build tackle2-addon-analyzer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shawn-hurley shawn-hurley force-pushed the bugfix/trigger-after-build branch from 9a3a975 to 110d5fc Compare January 8, 2026 21:24
@jmle jmle self-requested a review January 9, 2026 08:27
@shawn-hurley shawn-hurley merged commit ed6e9a6 into konveyor:main Jan 9, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants