UI 1264 pm window #251
Open
UI 1264 pm window #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missing functions  Thanks to @twostars and @stevewgr for asm code :)
JanekCode
approved these changes
Aug 26, 2024
Member
|
Awesome! Thanks for the pull-request @xGuTeK 🚀 As also discussed privately, I'll review it possibly on one of the weekends, because currently I'm unfortunately occupied with work. |
xGuTeK
added
the
official_client_code_review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link - #141
This pull request introduces whisper chat windows and enhances the server-side functionality for message targeting by adding support for message blocking. Currently, this blocking feature is implemented only on the server side, with the client-side lacking this functionality. We will need to address the client-side implementation of message blocking in a future update when we work on refining the main chat window.
I based the server-side function changes on the PDB of Ebenezer 1310, but the implementation of the private chat windows was done without using assembly code. Therefore, there may be differences, and it is necessary to verify against the client's assembly code.
💔 Thank you!
