Skip to content

feat(exec) Filter by tags in exec cmd #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
majki741 wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −15
Open

feat(exec) Filter by tags in exec cmd #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb7828d
feat(exec) Filter by tags in exec cmd
majki741 Feb 22, 2025
33ccdcb
Update Command Flags
majki741 Feb 22, 2025
fd6cf70
Other places where filter() is used.
majki741 Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/clip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ func init() {
`Display snippets in one line`)
clipCmd.Flags().StringVarP(&config.Flag.Delimiter, "delimiter", "d", "; ",
`Use delim as the command delimiter character`)
clipCmd.Flags().StringVarP(&config.Flag.FilterTag, "tag", "t", "",
`Filter tag`)
clipCmd.Flags().StringVarP(&config.Flag.FilterTag, "tags", "t", "",
`"Filter by specified tags as comma separated values"`)
}
4 changes: 2 additions & 2 deletions cmd/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,6 @@ func init() {
RootCmd.AddCommand(editCmd)
editCmd.Flags().StringVarP(&config.Flag.Query, "query", "q", "",
`Initial value for query`)
editCmd.Flags().StringVarP(&config.Flag.FilterTag, "tag", "t", "",
`Filter tag`)
editCmd.Flags().StringVarP(&config.Flag.FilterTag, "tags", "t", "",
`"Filter by specified tags as comma separated values"`)
}
4 changes: 2 additions & 2 deletions cmd/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ func init() {
`Enable colorized output (only fzf)`)
execCmd.Flags().StringVarP(&config.Flag.Query, "query", "q", "",
`Initial value for query`)
execCmd.Flags().StringVarP(&config.Flag.FilterTag, "tag", "t", "",
`Filter tag`)
execCmd.Flags().StringVarP(&config.Flag.FilterTag, "tags", "t", "",
"Filter by specified tags as comma separated values")
execCmd.Flags().BoolVarP(&config.Flag.Silent, "silent", "s", false,
`Suppress the command output`)
}
4 changes: 2 additions & 2 deletions cmd/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ func init() {
`Enable colorized output (only fzf)`)
searchCmd.Flags().StringVarP(&config.Flag.Query, "query", "q", "",
`Initial value for query`)
searchCmd.Flags().StringVarP(&config.Flag.FilterTag, "tag", "t", "",
`Filter tag`)
searchCmd.Flags().StringVarP(&config.Flag.FilterTag, "tags", "t", "",
`"Filter by specified tags as comma separated values"`)
searchCmd.Flags().StringVarP(&config.Flag.Delimiter, "delimiter", "d", "; ",
`Use delim as the command delimiter character`)
}
8 changes: 1 addition & 7 deletions cmd/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,7 @@ func filter(options []string, tag string) (commands []string, err error) {
// Filter the snippets by specified tag if any
if 0 < len(tag) {
var filteredSnippets snippet.Snippets
for _, snippet := range snippets.Snippets {
for _, t := range snippet.Tag {
if tag == t {
filteredSnippets.Snippets = append(filteredSnippets.Snippets, snippet)
}
}
}
filteredSnippets.Snippets = snippets.FilterByTags(strings.Split(tag, ","))
snippets = filteredSnippets
}

Expand Down