Switch to static build#197
Conversation
DEVELOPMENT.md
Outdated
|
|
||
| > @evankanderson is working on | ||
| > [fixing this](https://github.com/knative/website/issues/158) | ||
| If you want the old behavior of starting a local webserver, you can run |
There was a problem hiding this comment.
Due to the differences in the way the site is built and hosted online VS how the local webserver works, using only the local server to test the site can and did cause a lot of pain and trouble (early on during site development, and also #155).
I think for simply testing if an authored markdown file "looks" right and all the links work, this sounds like an improvement for sure (will get around to testing next week).
But I think since that this is the DEVELOPMENT.md file, we should be clear about how the local server can seem like everything works perfect but can then fails completely when deployed to Netlify.
Maybe:
Testing that authored markdown files render properly
VS.
Building the site how it gets hosted (ie. use this if new site features need local testing)
|
Yeah, I discovered in the course of trying to get #155 working that it was easier to debug or diff output if I had a full tree of files, rather than a running webserver. We've also found that |
There was a problem hiding this comment.
Nice workaround for the MacOS issues! I edited the descriptions to add more detail and context so that it doesn't feel like a black box. PTAL
Otherwise, works like a charm. Thanks, Evan!
(ill let the others test and provide the LGTM - and also allow everyone a chance to comment on my edits)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, RichieEscarez The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
in the edit, I add mention of how a full tree of files also gets created under |
|
/lgtm |
This avoids avoid FD-quota-related errors on MacOS X, and makes it easier to debug issues with rendering because you can actually open the files.
/assign @n3wscott @abrennan89