Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Switch to static build#197

Merged
knative-prow-robot merged 9 commits intoknative:masterfrom
evankanderson:static-build
Aug 11, 2020
Merged

Switch to static build#197
knative-prow-robot merged 9 commits intoknative:masterfrom
evankanderson:static-build

Conversation

@evankanderson
Copy link
Copy Markdown
Member

This avoids avoid FD-quota-related errors on MacOS X, and makes it easier to debug issues with rendering because you can actually open the files.

/assign @n3wscott @abrennan89

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 31, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2020
DEVELOPMENT.md Outdated

> @evankanderson is working on
> [fixing this](https://github.com/knative/website/issues/158)
If you want the old behavior of starting a local webserver, you can run
Copy link
Copy Markdown
Contributor

@RichieEscarez RichieEscarez Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the differences in the way the site is built and hosted online VS how the local webserver works, using only the local server to test the site can and did cause a lot of pain and trouble (early on during site development, and also #155).

I think for simply testing if an authored markdown file "looks" right and all the links work, this sounds like an improvement for sure (will get around to testing next week).

But I think since that this is the DEVELOPMENT.md file, we should be clear about how the local server can seem like everything works perfect but can then fails completely when deployed to Netlify.

Maybe:

Testing that authored markdown files render properly
VS.
Building the site how it gets hosted (ie. use this if new site features need local testing)

@evankanderson
Copy link
Copy Markdown
Member Author

Yeah, I discovered in the course of trying to get #155 working that it was easier to debug or diff output if I had a full tree of files, rather than a running webserver.

We've also found that hugo server fails on Mac unless you perform some extra environment setup in your shell, which seems to cause trouble for contributors.

Copy link
Copy Markdown
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workaround for the MacOS issues! I edited the descriptions to add more detail and context so that it doesn't feel like a black box. PTAL

Otherwise, works like a charm. Thanks, Evan!

(ill let the others test and provide the LGTM - and also allow everyone a chance to comment on my edits)

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2020
@RichieEscarez
Copy link
Copy Markdown
Contributor

...to debug or diff output if I had a full tree of files, rather than a running webserver.

in the edit, I add mention of how a full tree of files also gets created under content/en/ when you use the now -s option (they are overwritten whenever you rerun the script)

@n3wscott
Copy link
Copy Markdown

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@knative-prow-robot knative-prow-robot merged commit 3df790f into knative:master Aug 11, 2020
@evankanderson evankanderson deleted the static-build branch March 23, 2021 23:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants