keep TagToHostAnnotationKey alongside TagLabelKey#1129
keep TagToHostAnnotationKey alongside TagLabelKey#1129knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
|
@asami-okina: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
|
Welcome @asami-okina! It looks like this is your first PR to knative/networking 🎉 |
|
Hi @asami-okina. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1446fbb to
02fa195
Compare
Signed-off-by: Asami Okina <okinaasami@gmail.com>
02fa195 to
ac4036e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asami-okina, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
thanks for the PR 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 35 35
Lines 1005 1005
=======================================
Hits 938 938
Misses 53 53
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes
TagLabelKeyinregister.goso that consumers no longer need to hardcode it locallyhttps://github.com/knative-extensions/net-gateway-api/blob/main/pkg/reconciler/ingress/resources/httproute.go#L377-L380
/kind cleanup
Fixes #
Release Note
Docs