Skip to content

keep TagToHostAnnotationKey alongside TagLabelKey#1129

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
asami-okina:keep-tag-to-host-annotation-key
Apr 5, 2026
Merged

keep TagToHostAnnotationKey alongside TagLabelKey#1129
knative-prow[bot] merged 1 commit intoknative:mainfrom
asami-okina:keep-tag-to-host-annotation-key

Conversation

@asami-okina
Copy link
Copy Markdown
Contributor

@asami-okina asami-okina commented Apr 3, 2026

Changes

/kind cleanup

Fixes #

Release Note

NONE

Docs

@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 3, 2026

@asami-okina: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 3, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: asami-okina / name: Asami Okina (ac4036e)

@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 3, 2026

Welcome @asami-okina! It looks like this is your first PR to knative/networking 🎉

@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 3, 2026

Hi @asami-okina. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2026
@knative-prow knative-prow bot requested review from dprotaso and skonto April 3, 2026 14:30
@asami-okina asami-okina force-pushed the keep-tag-to-host-annotation-key branch from 1446fbb to 02fa195 Compare April 3, 2026 14:33
Signed-off-by: Asami Okina <okinaasami@gmail.com>
@asami-okina asami-okina force-pushed the keep-tag-to-host-annotation-key branch from 02fa195 to ac4036e Compare April 3, 2026 14:37
@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Apr 5, 2026

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asami-okina, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2026
@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Apr 5, 2026

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2026
@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Apr 5, 2026

thanks for the PR 🎉

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.33%. Comparing base (4103dd9) to head (ac4036e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files          35       35           
  Lines        1005     1005           
=======================================
  Hits          938      938           
  Misses         53       53           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot merged commit 4d3f1a4 into knative:main Apr 5, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants