Fix scrollback reset position in tsm_screen_sb_reset()#26
Merged
kdj0c merged 1 commit intokmscon:mainfrom Feb 28, 2026
Merged
Conversation
Contributor
|
Thanks for your PR. It looks good to me, so I merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sb_pos_num represents the number of scrollback lines above the currently visible screen.
When the terminal displays the latest output (normal mode), all scrollback lines are above the visible screen, therefore sb_pos_num == sb_count (the total number of lines in the scrollback buffer).
However, tsm_screen_sb_reset() currently sets sb_pos_num to 0 when leaving scrollback mode.
Instead, it appears that sb_pos_num should be restored to sb_count to correctly reflect normal mode.
This has been tested using tsm_screen_sb_get_line_count() and tsm_screen_sb_get_line_pos() in the scrollbar implementation done for DFBTerm