Skip to content

Conversation

@ThomasJejkal
Copy link
Contributor

@ThomasJejkal ThomasJejkal commented Jan 17, 2025

Summary by CodeRabbit

  • Dependency Updates

    • Updated Spring Boot to version 3.4.2
    • Updated Lombok and Maven Publish plugins to version 8.12
    • Updated OWASP Dependency Check plugin to version 12.0.1
    • Updated Spring Data Elasticsearch to version 5.4.2
    • Updated repo-core to version 1.2.5
    • Updated SpringDoc to version 2.8.4
  • Behavior Changes

    • Resources with GONE state are now visible to owners and administrators
    • ACL information retention modified for non-administrator users
  • Infrastructure

    • Updated Gradle wrapper to version 8.12.1
    • Updated Docker build action

renovate bot and others added 2 commits January 17, 2025 11:22
…ework.data-spring-data-elasticsearch-5.x

Update dependency org.springframework.data:spring-data-elasticsearch to v5.4.2
@coderabbitai
Copy link

coderabbitai bot commented Jan 17, 2025

Walkthrough

This pull request introduces a series of version updates and behavioral changes across multiple files in the project. The primary focus is on updating dependencies, plugins, and modifying the handling of deleted resources. Key changes include upgrading Spring Boot, Gradle, and various plugins to their latest minor versions, and adjusting the visibility of deleted resources for admin users. The modifications suggest improvements in dependency management and resource handling within the application.

Changes

File Change Summary
build.gradle - Updated Spring Boot plugin to v3.4.2
- Updated Lombok and Maven Publish Java plugins to v8.12
- Updated OWASP Dependency Check plugin to v12.0.1
- Updated spring-data-elasticsearch to v5.4.2
- Updated repo-core to v1.2.5
- Updated SpringDoc version to 2.8.4
.github/workflows/docker-publish.yml - Updated docker/build-push-action to new digest
gradle/wrapper/gradle-wrapper.properties - Updated Gradle distribution to v8.12.1
src/main/java/edu/kit/datamanager/repo/web/impl/DataResourceController.java - Removed resource filtering in response methods
src/test/java/*ControllerTest.java - Modified tests to expect successful GET requests for deleted resources by admin users
CHANGELOG.md - Added v1.5.8 section
- Documented changes in resource visibility and dependency updates

Possibly related PRs

Poem

🐰 A Gradle hop, versions take flight,
Dependencies dance in the CodeRabbit light,
Deleted resources now softly remain,
For admins to view without any pain,
Our code evolves with each small delight! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

renovate bot and others added 22 commits January 19, 2025 16:28
…ndencycheck-12.x

Update plugin org.owasp.dependencycheck to v12.0.1
…ush-action-digest

Update docker/build-push-action digest to ca877d9
…ven-publish-java-8.x

Update plugin io.freefair.maven-publish-java to v8.12
…mbok-8.x

Update plugin io.freefair.lombok to v8.12
…ework.boot-3.x

Update plugin org.springframework.boot to v3.4.2
…on_removed_for_Non-Administrator_Users

ACL information removed for Non-Administrator Users
@ThomasJejkal ThomasJejkal changed the title PR for v1.5.9 PR for v1.5.8 Jan 27, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
CHANGELOG.md (2)

19-20: Fix bare URL in changelog entry.

The changelog entry contains a bare URL. According to the Keep a Changelog format, URLs should be properly linked using Markdown syntax.

Apply this diff to fix the formatting:

-* ACL information no longer removed for Non-Administrator Users by @github-actions in https://github.com/kit-data-manager/base-repo/pull/381
+* ACL information no longer removed for Non-Administrator Users by @github-actions in [#381](https://github.com/kit-data-manager/base-repo/pull/381)
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

19-19: Bare URL used
null

(MD034, no-bare-urls)


24-33: Fix bare URLs in security updates section.

The security updates section contains multiple bare URLs. According to the Keep a Changelog format, URLs should be properly linked using Markdown syntax.

Apply this diff to fix the formatting:

-* Update dependency org.springframework.data:spring-data-elasticsearch to v5.4.2 by @renovate in https://github.com/kit-data-manager/base-repo/pull/372
-* Update plugin org.owasp.dependencycheck to v12.0.1 by @renovate in https://github.com/kit-data-manager/base-repo/pull/374
-* Update docker/build-push-action digest to ca877d9 by @renovate in https://github.com/kit-data-manager/base-repo/pull/378
-* Update plugin io.freefair.maven-publish-java to v8.12 by @renovate in https://github.com/kit-data-manager/base-repo/pull/377
-* Update plugin io.freefair.lombok to v8.12 by @renovate in https://github.com/kit-data-manager/base-repo/pull/376
-* Update dependency gradle to v8.12.1 by @renovate in https://github.com/kit-data-manager/base-repo/pull/379
-* Update plugin org.springframework.boot to v3.4.2 by @renovate in https://github.com/kit-data-manager/base-repo/pull/375
-* Update springDocVersion to v2.8.4 by @renovate in https://github.com/kit-data-manager/base-repo/pull/382
+* Update dependency org.springframework.data:spring-data-elasticsearch to v5.4.2 by @renovate in [#372](https://github.com/kit-data-manager/base-repo/pull/372)
+* Update plugin org.owasp.dependencycheck to v12.0.1 by @renovate in [#374](https://github.com/kit-data-manager/base-repo/pull/374)
+* Update docker/build-push-action digest to ca877d9 by @renovate in [#378](https://github.com/kit-data-manager/base-repo/pull/378)
+* Update plugin io.freefair.maven-publish-java to v8.12 by @renovate in [#377](https://github.com/kit-data-manager/base-repo/pull/377)
+* Update plugin io.freefair.lombok to v8.12 by @renovate in [#376](https://github.com/kit-data-manager/base-repo/pull/376)
+* Update dependency gradle to v8.12.1 by @renovate in [#379](https://github.com/kit-data-manager/base-repo/pull/379)
+* Update plugin org.springframework.boot to v3.4.2 by @renovate in [#375](https://github.com/kit-data-manager/base-repo/pull/375)
+* Update springDocVersion to v2.8.4 by @renovate in [#382](https://github.com/kit-data-manager/base-repo/pull/382)
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

25-25: Bare URL used
null

(MD034, no-bare-urls)


26-26: Bare URL used
null

(MD034, no-bare-urls)


27-27: Bare URL used
null

(MD034, no-bare-urls)


28-28: Bare URL used
null

(MD034, no-bare-urls)


29-29: Bare URL used
null

(MD034, no-bare-urls)


30-30: Bare URL used
null

(MD034, no-bare-urls)


31-31: Bare URL used
null

(MD034, no-bare-urls)


32-32: Bare URL used
null

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7588a8 and 3af37e1.

📒 Files selected for processing (1)
  • CHANGELOG.md (2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md

19-19: Bare URL used
null

(MD034, no-bare-urls)


25-25: Bare URL used
null

(MD034, no-bare-urls)


26-26: Bare URL used
null

(MD034, no-bare-urls)


27-27: Bare URL used
null

(MD034, no-bare-urls)


28-28: Bare URL used
null

(MD034, no-bare-urls)


29-29: Bare URL used
null

(MD034, no-bare-urls)


30-30: Bare URL used
null

(MD034, no-bare-urls)


31-31: Bare URL used
null

(MD034, no-bare-urls)


32-32: Bare URL used
null

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: coverage
  • GitHub Check: coverage
🔇 Additional comments (2)
CHANGELOG.md (2)

17-18: Version number follows semantic versioning.

The version number and date format follow the Keep a Changelog conventions.


330-331: Version comparison links are properly formatted.

The version comparison links follow the Keep a Changelog format and correctly link to the GitHub repository's compare view.

@ThomasJejkal ThomasJejkal merged commit c8d3a5b into main Jan 27, 2025
10 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants