fix(developer): handle .kps file that has no <Package> element#15622
Open
mcdurdin wants to merge 1 commit intofix/developer/15619-handle-missing-info-section-in-kmp-compilerfrom
Conversation
Fixes: #15621 Fixes: KEYMAN-DEVELOPER-37D Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
darcywong00
approved these changes
Feb 25, 2026
| static ERROR_NotAPackageFile = SevError | 0x000D; | ||
| static Error_NotAPackageFile = () => m( | ||
| this.ERROR_NotAPackageFile, | ||
| `Package source file is not a valid .kps file because it is missing the <Package> root element.`, |
Contributor
There was a problem hiding this comment.
👍 This looks like a more informative version of ERROR_InvalidPackageFile (l.62)
| } | ||
|
|
||
| if(!kpsPackage.Package) { | ||
| this.callbacks.reportMessage(DeveloperUtilsMessages.Error_NotAPackageFile()); |
Contributor
There was a problem hiding this comment.
Why doesn't l.38 generate an error message?
ermshiperete
approved these changes
Feb 25, 2026
| const kps = reader.read(input); | ||
|
|
||
| assert.isNull(kps); | ||
| assert.isTrue(callbacks.hasMessage(DeveloperUtilsMessages.ERROR_NotAPackageFile)); |
Contributor
There was a problem hiding this comment.
It would be good to call callbacks.clear() between the tests in beforeEach().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #15621
Fixes: KEYMAN-DEVELOPER-37D
Test-bot: skip