chore: redirect of some capital letters in url#1759
Merged
darcywong00 merged 4 commits intomasterfrom Jan 23, 2025
Merged
Conversation
Contributor
|
Relates to #691. |
mcdurdin
requested changes
Jan 16, 2025
.htaccess
Outdated
Comment on lines
28
to
32
| RedirectMatch "(.*)/ENGINE(.*)" "$1/engine$2" | ||
|
|
||
| RedirectMatch "(.*)/WEB(.*)" "$1/web$2" | ||
|
|
||
| RedirectMatch "(.*)/DESKTOP(.*)" "$1/windows$2" |
Member
There was a problem hiding this comment.
These are probably too generic. We should match the prefix precisely to avoid accidental matches
…into htaccess-capital-urls
Collaborator
Author
|
Changes are applied and ready for reviews. |
Collaborator
Author
|
Yes, @darcywong00. These are recently reported as well: |
mcdurdin
requested changes
Jan 22, 2025
Co-authored-by: Marc Durdin <marc@durdin.net>
mcdurdin
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More on: keymanapp/keyman.com#415.
The .htaccess validation may be overlapping a bit with the existing rules in the file but this should remove the registration of 404 Not found of the capital URLs:
Descriptive reports: https://docs.google.com/spreadsheets/d/1On3WrJMyDo3QboQvl7S1sbtD1z3HO3JH/edit?usp=sharing&ouid=115939244027961768677&rtpof=true&sd=true
This PR is ready for review.