Add test to detect unused crates and drop the currently unused ones #1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ansasaki
force-pushed
the
machete
branch
2 times, most recently
from
53629d7 to
918758b
Compare
Remove the following crates that are unused in keylime-agent: - glob - libc - reqwest - serde_derive Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Drop the following unused crates in keylime-push-model-agent: - assert_cmd - base64 - predicates - serde - serde_derive - static_assertions Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Drop the following unused crates in keylime lib: - once_cell - retry-policies - serde_derive - url Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
The new workflow uses cargo-machete to detect unused crates. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
With the changes on cargo files, it is necessary to update the specfiles used to build the packages on COPR for Fedora and CentOS Stream. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workflow that runs
cargo-machetedo detect unused crates.The currently unused crates are also dropped from the crates
Cargo.tomlfiles