Skip to content

Wait for in-flight goroutines to complete in tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoom-ua merged 1 commit into from
Jan 7, 2026
Merged

Wait for in-flight goroutines to complete in tests #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pipeliner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,15 @@ func testPipeliner(doError bool, doCancel bool) ([]int, error) {
for i := range v {
err := pipeliner.WaitForRoom(ctx)
if err != nil {
// Ensure any in-flight goroutines are complete before returning. Note that Flush does not actually wait if there is an error.
for pipeliner.hasOutstanding() {
<-pipeliner.ch
}
return v, err
}
go func(i int) { pipeliner.CompleteOne(f(ctx, i)) }(i)
}

err := pipeliner.Flush(ctx)
return v, err
}
Loading