Skip to content

Add terminating workspaces provider and example#94

Draft
mircea-cosbuc wants to merge 1 commit intokcp-dev:mainfrom
mircea-cosbuc:feat/add-terminating-workspace-provider
Draft

Add terminating workspaces provider and example#94
mircea-cosbuc wants to merge 1 commit intokcp-dev:mainfrom
mircea-cosbuc:feat/add-terminating-workspace-provider

Conversation

@mircea-cosbuc
Copy link
Copy Markdown

Summary

Add terminating workspaces provider and example

What Type of PR Is This?

Related Issue(s)

Fixes #89

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. dco-signoff: no Indicates the PR's author has not signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 29, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

Hi @mircea-cosbuc. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 29, 2026
Signed-off-by: Mircea Cosbuc <contact@mircea.dev>
@mircea-cosbuc mircea-cosbuc force-pushed the feat/add-terminating-workspace-provider branch from a17b50c to 042de5c Compare March 29, 2026 14:09
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Mar 29, 2026
@ntnn
Copy link
Copy Markdown
Member

ntnn commented Mar 29, 2026

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 29, 2026
Copy link
Copy Markdown
Member

@ntnn ntnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Yes, that looks good

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

@mircea-cosbuc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-multicluster-provider-test 042de5c link true /test pull-multicluster-provider-test

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ntnn ntnn added this to tbd Mar 29, 2026
@github-project-automation github-project-automation bot moved this to Backlog in tbd Mar 29, 2026
@ntnn ntnn moved this from Backlog to Reviewing in tbd Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Add terminating workspace provider

3 participants