Conversation
Move continuation signature-compatibility checks into a dedicated mockito.sameish subsystem and make Mock delegate to it. The new logic compares signatures structurally (including matcher internals) instead of calling matcher .matches() across stub signatures. This avoids executing user arg_that predicates during bookkeeping and prevents side effects/crashes from predicate evaluation against matcher objects. Add focused unit coverage in tests/sameish_test.py. Add chaining regressions that assert branch sharing for equivalent any_(int) signatures and reused arg_that predicates. These were the original fatal regressions that motivated the effort.
Continuation lookup now treats captor-style wildcard roots as structurally sameish so equivalent root selectors share the same chain continuation. Specifically, sameish comparison now handles call_captor(), *captor(), and **captor() sentinel wrappers without relying on object identity, and compares sentinel wrappers via their underlying captor matcher semantics. The tests were updated to reflect this contract in sameish unit coverage, and chaining coverage now includes call_captor/*captor/**captor branch-sharing scenarios.
When a chain branch resolves to an existing sameish root but binds different captor instances, stubbing now raises an InvocationError with guidance to reuse the same captor object. This avoids silent branch shadowing where one leaf becomes unreachable while still preserving strict behavior. Tests were expanded to cover sameish semantics for typed and untyped captor wrappers, as well as rejection of distinct typed *captor(any_(int)) chain roots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.