fix: ensure karma.config is passed (#192) #206
Conversation
|
Seems the change is pretty harmless. @johnjbarton What do you think? |
johnjbarton
left a comment
johnjbarton
left a comment
There was a problem hiding this comment.
I think this project needs some work on the package.json and such.
| var clientArguments | ||
| config = config || {} | ||
| clientArguments = config.args | ||
| return function () { |
There was a problem hiding this comment.
Could there be existing callers in other code that expect the argument to be used?
| clientArguments = config.args | ||
| return function () { | ||
| var config = karma.config || {} | ||
| var clientArguments = config.args |
There was a problem hiding this comment.
Move these two lines up before the return statement. They will execute during file-load so the clientArguments will be available then, rather than only later during the load-event handling.
That has no impact, but in the case of karma-jasmine, the config values can be used to reset jasmine.DEFAULT_TIMEOUT_INTERVAL and it must be set during file-load.
| } | ||
| /* eslint-disable no-unused-vars */ | ||
| var createMochaStartFn = function (mocha) { | ||
| var createMochaStartFn = function (karma, mocha) { |
There was a problem hiding this comment.
Make karma the second argument so existing code calling with one argument will work.
| config = config || {} | ||
| clientArguments = config.args | ||
| return function () { | ||
| var config = karma.config || {} |
There was a problem hiding this comment.
safer would be to leave the config parameter and
config = config ? config : (karma ? karma.config || {} : {}
2 participants
No description provided.