kagent-adk cli read host/port from environment #1244
+42
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Jausovec <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for reading HOST and PORT configuration from environment variables in the kagent-adk CLI. The implementation introduces a resolve_host_port helper function that attempts to merge command-line arguments, environment variables, and default values. However, the implementation has critical issues with priority logic that contradict the documented behavior.
Changes:
- Added
resolve_host_portfunction to handle host/port resolution with environment variable support - Updated
staticandrunCLI commands to accept optional host/port parameters with environment variable fallback - Modified parameter annotations to use
typer.Optionwithenvvarsupport
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.