Merged
Conversation
afedd29 to
e05df36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infos
N/A or Issue link
What is being delivered?
This pull request introduces several improvements to the project’s development workflow, dependency management, and test coverage. The most significant changes include the addition of a detailed pull request template, updates to dependency specifications, removal of legacy setup scripts, and new tests to improve reliability and error handling.
Project Documentation & Workflow:
.github/pull_request_template.mdto guide contributors in documenting changes, impacts, reversal plans, and monitoring strategies.Dependency Management:
requestsandurllib3dependency specifications inpyproject.tomlto use caret (^) syntax, ensuring compatibility with future minor releases.coverage,tblib,tox) frompyproject.tomlto streamline the development environment.setup.pyfile, fully transitioning dependency and packaging management to Poetry.Testing Improvements:
tests/test_helpers.pyto verify thatget_response_bodycorrectly falls back to parsing response text if JSON parsing fails.tests/test_hooks.pyto ensurecheck_for_errorsraises aTypeErrorwhen given an invalid allowed status list, improving error handling robustness.What impacts?
Reversal plan
Where to monitor
Doubts about the flow? Take a look at our Gitflow!
Doubts about the code standards? Take a look at the Playbook!