Skip to content

test: added missing coverage tests#2

Merged
niltonfrederico merged 4 commits intomainfrom
feature/improve-coverage
Nov 7, 2025
Merged

test: added missing coverage tests#2
niltonfrederico merged 4 commits intomainfrom
feature/improve-coverage

Conversation

@niltonfrederico
Copy link
Collaborator

Infos

N/A or Issue link

What is being delivered?

This pull request introduces several improvements to the project’s development workflow, dependency management, and test coverage. The most significant changes include the addition of a detailed pull request template, updates to dependency specifications, removal of legacy setup scripts, and new tests to improve reliability and error handling.

Project Documentation & Workflow:

  • Added a comprehensive pull request template in .github/pull_request_template.md to guide contributors in documenting changes, impacts, reversal plans, and monitoring strategies.

Dependency Management:

  • Updated requests and urllib3 dependency specifications in pyproject.toml to use caret (^) syntax, ensuring compatibility with future minor releases.
  • Removed unused or legacy development dependencies (coverage, tblib, tox) from pyproject.toml to streamline the development environment.
  • Deleted the legacy setup.py file, fully transitioning dependency and packaging management to Poetry.

Testing Improvements:

  • Added a test in tests/test_helpers.py to verify that get_response_body correctly falls back to parsing response text if JSON parsing fails.
  • Added a test in tests/test_hooks.py to ensure check_for_errors raises a TypeError when given an invalid allowed status list, improving error handling robustness.

What impacts?

  • N/A

Reversal plan

  • Don't

Where to monitor

  • N/A

Doubts about the flow? Take a look at our Gitflow!

Doubts about the code standards? Take a look at the Playbook!

@niltonfrederico niltonfrederico requested a review from a team as a code owner November 7, 2025 18:22
@niltonfrederico niltonfrederico force-pushed the feature/improve-coverage branch from afedd29 to e05df36 Compare November 7, 2025 18:30
@niltonfrederico niltonfrederico self-assigned this Nov 7, 2025
@niltonfrederico niltonfrederico merged commit e05df36 into main Nov 7, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant