Ensure that exporters are online AND registered

[NickCao]

Summary by CodeRabbit

• Chores
  • Updated resource readiness checks to wait for both "Online" and "Registered" conditions for exporters, ensuring more reliable status verification during operations.

[coderabbitai]

Walkthrough

The changes update the kubectl wait commands to require both Online and Registered conditions for exporter resources before proceeding. This adjustment is made in two locations: after starting all exporters together and after starting a single exporter. No other control flow or commands are affected.

Changes

File(s)	Change Summary
action.yml	Modified kubectl wait commands to wait for both Online and Registered conditions on exporters.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Action
    participant Exporter

    User->>Action: Start exporters
    loop For each exporter
        Action->>Exporter: Initiate exporter
    end
    loop For each exporter
        Action->>Exporter: Wait for Online and Registered conditions
        Exporter-->>Action: Signal Online and Registered
    end
    Action-->>User: Proceed after all conditions met

Loading

Possibly related PRs

• jumpstarter-dev/jumpstarter-e2e#9: Also modifies kubectl wait conditions for exporters, but changes the wait from Registered to Online and restructures client commands.

Poem

Awaiting exporters, both Online and Registered,
The command line rabbit hops, never flustered.
Two checks instead of one,
Before the tests are done—
In YAML fields, our patience is mustered!
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

action.yml (2)

146-148: Require both Online & Registered conditions; add timeout to avoid hangs
The updated wait commands now correctly enforce both Online and Registered statuses per PR #17’s objective. To guard against indefinite blocking if a resource fails to reach the conditions, consider adding a --timeout flag and consolidating the three waits into a single command:

- kubectl -n default wait --for=condition=Online --for=condition=Registered exporters.jumpstarter.dev/test-exporter-oidc
- kubectl -n default wait --for=condition=Online --for=condition=Registered exporters.jumpstarter.dev/test-exporter-sa
- kubectl -n default wait --for=condition=Online --for=condition=Registered exporters.jumpstarter.dev/test-exporter-legacy
+ kubectl -n default wait --timeout=3m --for=condition=Online --for=condition=Registered \
+   exporters.jumpstarter.dev/test-exporter-oidc,test-exporter-sa,test-exporter-legacy

---

162-162: Mirror timeout for single-exporter wait
The standalone wait now also checks both conditions, which is correct. Add a timeout here too for consistency and to prevent the workflow from hanging if the exporter never becomes ready:

- kubectl -n default wait --for=condition=Online --for=condition=Registered exporters.jumpstarter.dev/test-exporter-oidc
+ kubectl -n default wait --timeout=2m -n default --for=condition=Online --for=condition=Registered \
+   exporters.jumpstarter.dev/test-exporter-oidc

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13d22ec and 99eb2e5.

📒 Files selected for processing (1)

• action.yml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: test (ubuntu-24.04-arm)
• GitHub Check: test (ubuntu-24.04)