Skip to content

Add proper management of parameter times quadratic terms#206

Merged
odow merged 17 commits intomasterfrom
jg/cubic
Feb 17, 2026
Merged

Add proper management of parameter times quadratic terms#206
odow merged 17 commits intomasterfrom
jg/cubic

Conversation

@joaquimg
Copy link
Member

@joaquimg joaquimg commented Feb 15, 2026

Closes #144

Should we remove QuadraticObjectiveCoef in this PR?
A: To do in a followup PR

Claude usage disclosure:
1 - I wrote a plan and iterated with claude on it.
2 - claude wrote a first pass.
3 - I have been cleaning up some mess for the last 2-days.

@joaquimg joaquimg closed this Feb 15, 2026
@joaquimg joaquimg reopened this Feb 15, 2026
@joaquimg
Copy link
Member Author

Pkg manager is failing:

  Installing known registries into `~/.julia`
ERROR: LoadError: could not download https://pkg.julialang.org/registry/23338594-aafe-5451-b93e-139f81909106/fa18e8ce9c6fdb57188f3634953c5c532f7ba466 
Exception: RequestError: HTTP/2 404 while requesting https://pkg.julialang.org/registry/23338594-aafe-5451-b93e-139f81909106/fa18e8ce9c6fdb57188f3634953c5c532f7ba466

@codecov
Copy link

codecov bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (583615a) to head (8fde4f2).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   99.19%   99.38%   +0.19%     
==========================================
  Files           5        9       +4     
  Lines        1487     1949     +462     
==========================================
+ Hits         1475     1937     +462     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow
Copy link
Member

odow commented Feb 15, 2026

Thoughts on simplifying the documentation here: #207

We could move the PH tutorial to JuMP. I don't think POI is the right place for it. They're also not tested.

@odow
Copy link
Member

odow commented Feb 15, 2026

How much of this was Claude?

@joaquimg
Copy link
Member Author

How much of this was Claude?

1 - I wrote a plan and the iterated with claude
2 - claude wrote a first pass
3 - I have been cleaning up some mess for the last 2-days

@joaquimg
Copy link
Member Author

I am happy to move tutorials out of here

@joaquimg
Copy link
Member Author

joaquimg commented Feb 15, 2026

best claude use case: handle ScalarQuadraticFunction's 2 versus 1/2

@odow
Copy link
Member

odow commented Feb 16, 2026

Okay. Rebase, delete the plan, and add some minimal docs. I've copy-pasted the PH tutorial; I'll add it to JuMP, and then we can switch it to POI once we tag the next release.

@joaquimg
Copy link
Member Author

Remove old quadratic stuff in a follow-up PR?

@odow
Copy link
Member

odow commented Feb 16, 2026

Yeah a different PR.

@odow
Copy link
Member

odow commented Feb 16, 2026

I rewrote the PH tutorial jump-dev/JuMP.jl#4117.

Once we tag a new version of POI, we can change from Ipopt to HiGHS.

@odow
Copy link
Member

odow commented Feb 16, 2026

I'm going to require 100% test coverage before we merge this.

joaquimg and others added 4 commits February 15, 2026 23:29
Clarify the conditions for cubic terms and remove redundant attention section.
@joaquimg
Copy link
Member Author

I'm going to require 100% test coverage before we merge this.

Me too, I am working on it.

@joaquimg joaquimg requested a review from odow February 17, 2026 00:26
@joaquimg
Copy link
Member Author

@odow , this should be ready

@odow odow merged commit 887e008 into master Feb 17, 2026
8 checks passed
@odow odow deleted the jg/cubic branch February 17, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Handle "Constant * Parameter * Variable * Variable" with ScalarNonlinearFunction support

2 participants