Skip to content

Comments

Rewrite solver.jl#34

Open
odow wants to merge 8 commits intomainfrom
od/solver
Open

Rewrite solver.jl#34
odow wants to merge 8 commits intomainfrom
od/solver

Conversation

@odow
Copy link
Member

@odow odow commented Feb 20, 2026

Needs #33

@odow
Copy link
Member Author

odow commented Feb 23, 2026

Okay. I've gone full Rambo and refactored everything so this is breaking.

I've also removed many of the "option" controlling attributes. I don't think we want flexibility in how the algorithm runs. We want a simple set-and-forget.

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 87.14286% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.14%. Comparing base (8b17520) to head (3890595).

Files with missing lines Patch % Lines
src/MathOptIIS.jl 87.31% 43 Missing ⚠️
src/interval.jl 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   95.44%   87.14%   -8.31%     
==========================================
  Files           4        2       -2     
  Lines         395      350      -45     
==========================================
- Hits          377      305      -72     
- Misses         18       45      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant