[6.1] fix(cookie auth): fix error language translation #46576
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecpromotion
changed the title
|
@NicolasDerumigny - how exactly do I do this: "Try to log in twice with the exact same cookie using the cookie authentication plugin, triggering a failed login" ? I'll gladly test the PR, I just don't know how to do that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for .
Summary of Changes
Apply translation to
PLG_AUTHENTICATION_COOKIE_ERROR_LOG_LOGIN_FAILEDstring.Testing Instructions
Try to log in twice with the exact same cookie using the cookie authentication plugin, triggering a failed login (safety protection).
Actual result BEFORE applying this Pull Request
Joomla's log logs
PLG_AUTHENTICATION_COOKIE_ERROR_LOG_LOGIN_FAILEDExpected result AFTER applying this Pull Request
Joomla's log logs
Cookie login failed for user <user>Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed