Fix race detector going off by nil check outside lock#38
Open
rreuvekamp wants to merge 3 commits intojoncrlsn:v2from
Open
Fix race detector going off by nil check outside lock#38rreuvekamp wants to merge 3 commits intojoncrlsn:v2from
rreuvekamp wants to merge 3 commits intojoncrlsn:v2from
Conversation
It is done in SizeUnsafe anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our CI, the race detector is sometimes warning about a race happening in this library that we use. In our case, Size was ran in a separate goroutine than the one that calls Close. And Size checks fileLock before deciding whether or not to get a lock. It should however not check fileLock before being locked.