New JKParseOptionPermitLeadingZero option#127
Open
robertmryan wants to merge 2 commits intojohnezang:masterfrom
robertmryan:master
Open
New JKParseOptionPermitLeadingZero option#127robertmryan wants to merge 2 commits intojohnezang:masterfrom robertmryan:master
JKParseOptionPermitLeadingZero option#127robertmryan wants to merge 2 commits intojohnezang:masterfrom
robertmryan:master
Conversation
…hen parsing numeric values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally when parsing numeric values, leading zeros are considered a parsing error. This is the correct behavior, but while assisting an individual diagnose a parsing error due to incorrectly formed JSON (see this Stack Overflow question), I suggested that he might be able to adjust
jk_parse_numberto permit leading zeros.So, I offer this pull request with trepidation (as the correct resolution for that individual's problem is to fix his JSON), but nonetheless I thought I'd share this with you. Feel free to accept, improve, or simply reject/close this pull request as you see fit.