Major rewrite, BC breaks #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianRiesen
force-pushed
the
welcome-to-2020
branch
4 times, most recently
from
ce39f87 to
4b3bc5b
Compare
* Pushed everything up to PHP 7.4 and using language features * Refactored parser to be simpler * Added model for document (all lists) and items (individual sublists) * Ability to fetch item by id from document * Added to the parser to recognize boards and flag them accordingly * Login and sessions can now be handled easier * When updating an item, you call the client with it and the client figures out what needs to be updated and makes the minimal amount of API calls to accomplish the wanted updates. Still open: * Handle mirrors in parsing, export and updates. Maybe something to do later on, but not for this one.
ChristianRiesen
force-pushed
the
welcome-to-2020
branch
from
4b3bc5b to
bc9a35a
Compare
johansatge
approved these changes
Mar 28, 2021
Owner
johansatge
left a comment
johansatge
left a comment
There was a problem hiding this comment.
Hello @ChristianRiesen,
I had a deep look today and the new structure looks awesome 💯 thanks again for the work you put in this.
I took the liberty to invite you as contributor so you can merge whenever you want to.
johansatge
reviewed
Mar 28, 2021
| { | ||
| "name": "johansatge/workflowy-php", | ||
| "description": "An unofficial WorkFlowy API", | ||
| "version": "0.2.3", |
Owner
There was a problem hiding this comment.
I didn't use composer/Packagist for a long time, isn't the version mandatory?
Collaborator
Author
There was a problem hiding this comment.
Nope, you do tags, and packagist gets your info through that, knowing which version it is.
Collaborator
Author
|
Thanks for the invite! I do have to do some small tests still, but then I'd gladly merge and tag this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still open:
This will not work with PHP 8 since the changes to curl. I might make another version where the actual HTTP client is optional and can be chosen, so it would be compatible with PHP 7.4 and PHP 8.